🌱 Bump boxcutter to v0.13.0#2617
🌱 Bump boxcutter to v0.13.0#2617openshift-merge-bot[bot] merged 1 commit intooperator-framework:mainfrom
Conversation
Bumps boxcutter to latest version which now contains the FieldValue probe, which allows us to remove it from our codebase. Signed-off-by: Daniel Franz <dfranz@redhat.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR bumps the boxcutter dependency to v0.13.0, which now provides the FieldValueProbe implementation. As a result, the custom implementation of FieldValueProbe and its tests are removed from the codebase, with usage updated to delegate to boxcutter's provided implementation.
Changes:
- Updated boxcutter dependency from v0.12.0 to v0.13.0 in go.mod and go.sum
- Removed the custom
FieldValueProbestruct and its implementation methods frominternal/operator-controller/applier/phase.go - Updated
internal/operator-controller/controllers/clusterobjectset_controller.goto useprobing.FieldValueProbe(from boxcutter) instead ofapplier.FieldValueProbe - Removed unused imports and the corresponding tests from
internal/operator-controller/applier/phase_test.go
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Bumped boxcutter dependency to v0.13.0 |
| go.sum | Updated checksum for boxcutter v0.13.0 |
| internal/operator-controller/controllers/clusterobjectset_controller.go | Changed FieldValueProbe call from applier to probing package, removed applier import |
| internal/operator-controller/applier/phase.go | Removed FieldValueProbe struct implementation and related unused imports |
| internal/operator-controller/applier/phase_test.go | Removed Test_FieldValueProbe test and unused test imports |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2617 +/- ##
=======================================
Coverage 68.85% 68.86%
=======================================
Files 139 139
Lines 9931 9902 -29
=======================================
- Hits 6838 6819 -19
+ Misses 2578 2572 -6
+ Partials 515 511 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
camilamacedo86
left a comment
camilamacedo86
left a comment
There was a problem hiding this comment.
/approve
Thank you 🎉
openshift-ci
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, rashmigottipati The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit c304741
into
operator-framework:main
Bumps boxcutter to latest version which now contains the FieldValue probe, which allows us to remove it from our codebase.
Description
Reviewer Checklist